-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dynamic expressions on left hand side of match statements #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Full logs: https://github.com/onthegomap/planetiler/actions/runs/11291219396 |
Quality Gate passedIssues Measures |
This was referenced Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow left-hand dynamic expressions on the left-hand side of a match statement in addition to just tag names so you can do something like this to match on fields by ID:
The expression can be
feature.source
feature.source_layer
feature.osm_timestamp
feature.osm_type
etc.This also adds an
any
geometry type that passes through any point/line/polygon and makes geometry optional on features (defaults to any).As a followup a
${feature.source}
/${feature.source_layer}
expression could be converted to a matchSource/matchSourceLayer expression to optimize execution a bit more.