Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HaveEach(): Doc Comments Contradictory #703

Closed
jgrieger opened this issue Oct 10, 2023 · 1 comment
Closed

HaveEach(): Doc Comments Contradictory #703

jgrieger opened this issue Oct 10, 2023 · 1 comment

Comments

@jgrieger
Copy link

The following doc comment:

gomega/matchers.go

Line 384 in 375648c

// Please note that if actual is empty, HaveEach always will succeed.

does not fit to the implementation anymore:

gomega/matchers/have_each_matcher.go

Line 27 in 375648c

return false, fmt.Errorf("HaveEach matcher expects a non-empty array/slice/map. Got:\n%s",

The new behavior war introduced with #524.

Please let me know if I shall update the doc comment.
@onsi
Copy link
Owner

onsi commented Oct 11, 2023

yes please do, thanks!

onsi pushed a commit that referenced this issue Oct 17, 2023
@jgriegershs @onsi
#703 doc(matchers): HaveEach() doc comment updated
2705bdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@onsi @jgrieger