Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README with Go 1.6+, Golang -> Go #409

Merged
merged 2 commits into from
Dec 14, 2017
Merged

Update README with Go 1.6+, Golang -> Go #409

merged 2 commits into from
Dec 14, 2017

Conversation

iandelahorne
Copy link
Collaborator

Address parts of #406 for the README

  • We support Go 1.6+ in CI, in line with what the Go project supprots
  • Point to official Go installation instructions
  • Replace Golang with Go

Update README with Go 1.6+, Golang -> Go
17f6b97 
Address parts of onsi#406 for the README
- We support Go 1.6+ in CI, in line with what the Go project supprots
- Point to official Go installation instructions
- Replace Golang with Go
@williammartin
Copy link
Collaborator

LGTM, maybe not "need" 1.6 but suggest due to what we support/test. Also maybe if you push the build will run again and we can see that failure is a flake heh

@williammartin williammartin merged commit bc14b66 into onsi:master Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onsi onsi Awaiting requested review from onsi

@williammartin williammartin Awaiting requested review from williammartin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iandelahorne @williammartin