Merge pull request #438 from onsi/issue-436

Do not set the run time of a spec when the dryRun flag is used Solves #436
onsi · Mar 12, 2018 · ba8e856 · ba8e856
2 parents 9008c7b + 457e2d9
commit ba8e856
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/internal/spec/spec.go b/internal/spec/spec.go
@@ -98,7 +98,7 @@ func (spec *Spec) Summary(suiteID string) *types.SpecSummary {
 	componentCodeLocations[len(spec.containers)] = spec.subject.CodeLocation()
 
 	runTime := spec.runTime
-	if runTime == 0 {
+	if runTime == 0 && !spec.startTime.IsZero() {
 		runTime = time.Since(spec.startTime)
 	}
 

diff --git a/internal/specrunner/spec_runner_test.go b/internal/specrunner/spec_runner_test.go
@@ -235,6 +235,13 @@ var _ = Describe("Spec Runner", func() {
 				Ω(reporter1.EndSummary.NumberOfPassedSpecs).Should(Equal(0))
 				Ω(reporter1.EndSummary.NumberOfFailedSpecs).Should(Equal(0))
 			})
+
+			It("should not report a slow test", func() {
+				summaries := reporter1.SpecSummaries
+				for _, s := range summaries {
+					Expect(s.RunTime).To(BeZero())
+				}
+			})
 		})
 	})