Skip to content

Conversation

@JGallot
Copy link
Contributor

@JGallot JGallot commented Nov 3, 2023

Hi,

here is a tiny patch against XSS injection thanks of URL.

We had a security report about this.

Without the patch you can close commentary brackets in the url and run JS scripts adding in url

Example of bad hacker URL (only add text : xss visible in source code)
https://www.myredmine.com/projects/myproject--%3E%3Ch1%3Exss%3C!--/issues

@onozaty onozaty self-assigned this Nov 3, 2023
@onozaty
Copy link
Owner

onozaty commented Nov 3, 2023

Thanks for the pull request. I will check it out.

@onozaty onozaty merged commit ec43eed into onozaty:master Nov 4, 2023
onozaty added a commit that referenced this pull request Nov 4, 2023
@onozaty
Copy link
Owner

onozaty commented Nov 4, 2023

Released at v3.4.1.

I have not found a way to embed the script.
This is because if you try to embed the intended closing tag, it is treated as a URL.
Therefore, security issues are minor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants