Skip to content

Fix bug in topk casts affecting other input consumers #1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2021
Merged

Fix bug in topk casts affecting other input consumers #1674

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a29099
Fix bug in topk casts affecting other input consumers
TomWildenhain-Microsoft Aug 13, 2021
9d7b16d
Merge branch 'master' into tom/fix_topk_bug
TomWildenhain-Microsoft Aug 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tf2onnx/onnx_opset/tensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1172,7 +1172,7 @@ def any_version_after10(cls, opset, ctx, node, **kwargs):
# cast X if needed
if dtypes[0] != onnx_pb.TensorProto.FLOAT:
# opset-10 supports types other than float but onnxruntime does not
ctx.insert_new_node_on_output("Cast", node.input[0], to=onnx_pb.TensorProto.FLOAT)
ctx.insert_new_node_on_input(node, "Cast", node.input[0], input_index=0, to=onnx_pb.TensorProto.FLOAT)
ctx.insert_new_node_on_output("Cast", node.output[0], to=dtypes[0])
# cast the index output to int32
cast_out = ctx.insert_new_node_on_output("Cast", node.output[1], name=utils.make_name(node.name), to=dtypes[1])
Expand Down