Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement converter for _ConstantPredictor #979

Merged
merged 4 commits into from
Mar 18, 2023
Merged

Implement converter for _ConstantPredictor #979

merged 4 commits into from
Mar 18, 2023

Conversation

xadupre
Copy link
Collaborator

@xadupre xadupre commented Mar 15, 2023 •
edited
Loading

Fixes #977.

@xadupre
Implement converter for _ConstantPredictor
eae7d7e 
Signed-off-by: xadupre <xadupre@microsoft.com>
@xadupre xadupre mentioned this pull request Mar 15, 2023
Closed
xadupre added 3 commits March 15, 2023 16:40
@xadupre
add test for double
edf1c62 
Signed-off-by: xadupre <xadupre@microsoft.com>
@xadupre
fix shape
10a3c8e 
Signed-off-by: xadupre <xadupre@microsoft.com>
@xadupre
remove unused variable
1daf7fe 
Signed-off-by: xadupre <xadupre@microsoft.com>
@xadupre xadupre requested a review from xiaowuhu March 16, 2023 23:31
xiaowuhu
xiaowuhu approved these changes Mar 18, 2023
View reviewed changes
Copy link
Collaborator

@xiaowuhu xiaowuhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~!

@xiaowuhu xiaowuhu merged commit 2432f70 into onnx:main Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaowuhu xiaowuhu xiaowuhu approved these changes

Assignees
No one assigned
Labels
converter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot convert OneVsRestClassifier
2 participants
@xadupre @xiaowuhu