-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type annotations and fix some lint warnings in Python code #6473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6473 +/- ##
==========================================
- Coverage 57.23% 57.23% -0.01%
==========================================
Files 507 507
Lines 31447 31437 -10
Branches 3543 3542 -1
==========================================
- Hits 18000 17993 -7
+ Misses 12597 12595 -2
+ Partials 850 849 -1 ☔ View full report in Codecov by Sentry. |
cyyever
force-pushed
the
pylint2
branch
3 times, most recently
from
October 20, 2024 06:10
35174ed
to
a6156ff
Compare
@justinchuby More fixes. |
xadupre
reviewed
Oct 21, 2024
xadupre
reviewed
Oct 21, 2024
Signed-off-by: cyy <cyyever@outlook.com>
Signed-off-by: cyy <cyyever@outlook.com>
Signed-off-by: cyy <cyyever@outlook.com>
Signed-off-by: cyy <cyyever@outlook.com>
Signed-off-by: cyy <cyyever@outlook.com>
justinchuby
approved these changes
Oct 21, 2024
cc @xadupre for approval |
xadupre
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More robust type checking in Python.
Motivation and Context
For better code