Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations and fix some lint warnings in Python code #6473

Merged
merged 5 commits into from
Oct 23, 2024

Conversation

cyyever
Copy link
Contributor

@cyyever cyyever commented Oct 20, 2024

Description

More robust type checking in Python.

Motivation and Context

For better code

@cyyever cyyever requested review from a team as code owners October 20, 2024 03:10
@cyyever cyyever marked this pull request as draft October 20, 2024 03:10
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 70.45455% with 13 lines in your changes missing coverage. Please review.

Project coverage is 57.23%. Comparing base (651d579) to head (edb7c6a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
onnx/reference/ops/experimental/_op_list.py 38.88% 10 Missing and 1 partial ⚠️
.../reference/ops/aionnx_preview_training/_op_list.py 87.50% 0 Missing and 1 partial ⚠️
onnx/reference/ops/aionnxml/_op_list.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6473      +/-   ##
==========================================
- Coverage   57.23%   57.23%   -0.01%     
==========================================
  Files         507      507              
  Lines       31447    31437      -10     
  Branches     3543     3542       -1     
==========================================
- Hits        18000    17993       -7     
+ Misses      12597    12595       -2     
+ Partials      850      849       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cyyever cyyever force-pushed the pylint2 branch 3 times, most recently from 35174ed to a6156ff Compare October 20, 2024 06:10
@cyyever cyyever marked this pull request as ready for review October 20, 2024 06:17
@cyyever
Copy link
Contributor Author

cyyever commented Oct 21, 2024

@justinchuby More fixes.

Signed-off-by: cyy <cyyever@outlook.com>
Signed-off-by: cyy <cyyever@outlook.com>
Signed-off-by: cyy <cyyever@outlook.com>
Signed-off-by: cyy <cyyever@outlook.com>
Signed-off-by: cyy <cyyever@outlook.com>
@justinchuby
Copy link
Contributor

cc @xadupre for approval

@xadupre xadupre added this pull request to the merge queue Oct 23, 2024
Merged via the queue into onnx:main with commit 8896bee Oct 23, 2024
33 checks passed
@cyyever cyyever deleted the pylint2 branch October 23, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants