Skip to content

Conversation

@justinchuby
Copy link
Member

@justinchuby justinchuby commented Sep 30, 2025

When the value type is not known, we don't know where to store the shape inside a type proto. This change will make the serializer skip serializing the shape instead of error out.

Fix #202

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby requested review from a team and titaiwangms as code owners September 30, 2025 16:22
@justinchuby justinchuby added bug Something isn't working topic: bug fix and removed bug Something isn't working labels Sep 30, 2025
@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.78%. Comparing base (e6a9b8b) to head (7e9e1f0).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/onnx_ir/serde.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
- Coverage   76.78%   76.78%   -0.01%     
==========================================
  Files          40       40              
  Lines        4903     4914      +11     
  Branches      976      978       +2     
==========================================
+ Hits         3765     3773       +8     
- Misses        853      856       +3     
  Partials      285      285              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby added this to the 0.1.10 milestone Sep 30, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby enabled auto-merge (squash) September 30, 2025 19:04
@justinchuby justinchuby merged commit ec6f7be into main Sep 30, 2025
23 checks passed
@justinchuby justinchuby deleted the justinchu/value-field branch September 30, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix shape serialization (whichof)

3 participants