React 19 support #170
Merged
React 19 support #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: update MutableRefObject import to use React namespace * fix: update dependencies in useEffect hooks for better stability and clean up props spreading * fix: update devDependencies and dependencies for compatibility with latest versions * fix: update dependencies and scripts for compatibility with latest versions * fix: update Android build configuration for compatibility and enable new architecture * fix: update dependencies in yarn * fix: update type definitions
There was a problem hiding this comment.
Pull Request Overview
This PR adds React 19 support and updates key platform-specific configurations and component behaviors.
- Introduces a new Swift-based AppDelegate for iOS to initialize React Native components without an Objective-C delegate.
- Enhances remote data fetching components with improved error handling and logging in TypeScript.
- Updates the Android MainApplication and Gemfile to support new architectures and dependency requirements.
Reviewed Changes
Copilot reviewed 18 out of 30 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| example/ios/AutocomleteDropdownPlayground/AppDelegate.swift | New Swift AppDelegate implementation for React Native integration |
| example/ios/AutocomleteDropdownPlayground/AppDelegate.h | Removal of the Objective-C AppDelegate implementation |
| example/components/RemoteDataSetExample3.tsx | Added error handling using .catch() and .finally() in data fetching logic |
| example/components/RemoteDataSetExample2.tsx | Typed the searchRef reference and enhanced log messages |
| example/components/RemoteDataSetExample.tsx | Modified promise chaining to include a delay simulation and error handling |
| example/android/app/src/main/java/com/autocomletedropdownplayground/MainApplication.kt | Updated SoLoader initialization to use the new OpenSourceMergedSoMapping parameter |
| example/tests/App.test.tsx | Updated test syntax to use ReactTestRenderer with act() |
| example/Gemfile | Updated gems and added new dependencies to support Ruby 3.4.0 changes |
Files not reviewed (12)
- example/.bundle/config: Language not supported
- example/android/app/build.gradle: Language not supported
- example/android/build.gradle: Language not supported
- example/android/gradle.properties: Language not supported
- example/android/gradle/wrapper/gradle-wrapper.properties: Language not supported
- example/android/gradlew: Language not supported
- example/android/gradlew.bat: Language not supported
- example/ios/AutocomleteDropdownPlayground.xcodeproj/project.pbxproj: Language not supported
- example/ios/AutocomleteDropdownPlayground/AppDelegate.mm: Language not supported
- example/ios/AutocomleteDropdownPlayground/main.m: Language not supported
- example/ios/AutocomleteDropdownPlaygroundTests/AutocomleteDropdownPlaygroundTests.m: Language not supported
- example/ios/AutocomleteDropdownPlaygroundTests/Info.plist: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.