feat: add enableLoadingIndicator prop for activity indicator control … #160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
enableLoadingIndicator
prop to provide better control over the visibility of the activity indicator during loading states.The current implementation has a limitation where the
RightIconComponent
may visually dangle or shift improperly when transitioning from a loading (true) to not loading (false) state, particularly when using a custom right button with showClear set to false.The issue arises due to the conditional rendering of the clear button component, which does not account for cases where the loading indicator might be undesirable or visually intrusive. Here’s the problematic segment:
With the addition of the
enableLoadingIndicator
boolean, users will have the flexibility to enable or disable the loading indicator based on their specific needs, thus preventing the unwanted dangling effect of the RightIconComponent during the load transition.Attached is a video demonstrating the issue with:
showClear = false
RightIconComponent = <CustomComponent>
Enregistrement.de.l.ecran.2025-02-01.a.20.43.17.mov