Feat/simplified top bar controls #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drfarrell
requested changes
Dec 14, 2024
There was a problem hiding this comment.
This makes the UI look so so clean I'm excited about this! It will pair really well with the window UI in the sidebar... I'm excited about it!
I took a pass through it, added a bunch of style improvements that improve the UX and overall-feel, but I couldn't tackle two issues.
- The Design / Interact mode white top bar seems out of sync. I can't find out how to fix it so the bar slides over the interact mode like before.
- In interact mode there is some odd click-behavior when I click the top bar. Perhaps it is some of the edits I made, but when I click to edit things it flickers to gray for one click, and is generally a bit buggy.
Not sure if you can solve either of these @abhiroopc84, but if not, we can bring-in the big guns of Kiet.
This was
linked to
issues
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Untitled.video.-.Made.with.Clipchamp.73.mp4
#810
#811
What is the purpose of this pull request?