-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix performance of chat panel during streaming #3020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify the necessity of the observer wrapper and consider adding memoization.
The component is now wrapped with
observer(), but scanning the implementation reveals no obvious access to MobX observable properties. All props appear to be plain values (strings, booleans,ToolUIPart), and the component body only accesses standard properties liketoolPart.type,toolPart.state, etc.Additionally, other components in this PR (mentioned in the AI summary) follow a
memo(observer(...))pattern for consistency and performance, but this component only usesobserver().Run the following script to verify if
ToolUIPartor its accessed properties contain MobX observables:If
ToolUIPartdoes not contain observables, consider removing theobserver()wrapper. Otherwise, for consistency with other components in this PR, apply this pattern:Also applies to: 12-12, 230-230
🏁 Script executed:
Length of output: 27
🏁 Script executed:
Length of output: 2019
🏁 Script executed:
Length of output: 8589
Remove the unnecessary
observer()wrapper—this component does not access any MobX observables.The component only receives plain props (strings, boolean,
ToolUIParttype from theaipackage) and accesses standard property values without any MobX store hooks or observable patterns. Wrapping a component withobserver()when it doesn't access observables adds unnecessary overhead without providing any benefit. The applied prop is passed to child components as a plain prop, not indicating MobX reactivity tracking in this component.Remove the observer wrapper and import:
🤖 Prompt for AI Agents