fix: some gpt-5 stutter #2836

Kitenite · 2025-09-13T08:01:28Z

Description

Related Issues

Type of Change

Testing

Screenshots (if applicable)

Additional Notes

Important

Fix GPT-5 stutter by updating dependencies and refactoring chat message handling components.

Dependencies:
- Update @ai-sdk/react to 2.0.44 and ai to 5.0.44 in package.json and bun.lock.
Chat Message Handling:
- Refactor ChatMessages in index.tsx to use new MessageList component.
- Remove useMemo and useCallback hooks for message rendering logic.
- Simplify StreamMessage logic in stream-message.tsx.
New Components:
- Add MessageList component in message-list.tsx for rendering chat messages.
Function Changes:
- Modify handleToolCall in tools.ts to accept addToolResult callback for tool result handling.

^{This description was created by}^{for 137e519. You can customize this summary. It will automatically update as commits are pushed.}

Summary by CodeRabbit

Refactor
- Streamlined chat rendering to use engine messages with a new centralized message list.
- Simplified streaming behavior and loading state to a single “Thinking…” indicator.
- Improved empty-state handling and reduced re-render complexity.
Style
- Updated reasoning block to conditionally handle overflow when not streaming.
- Applied tighter, smaller Markdown styling for reasoning content.
Chores
- Upgraded AI-related dependencies across the app and packages to latest minor versions.

vercel · 2025-09-13T08:01:33Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Ready	Preview	Comment	Sep 13, 2025 8:01am
web	Building	Preview	Comment	Sep 13, 2025 8:01am

supabase · 2025-09-13T08:01:35Z

This pull request has been ignored for the connected project wowaemfasoptxrdjhilu because there are no changes detected in apps/backend/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

coderabbitai · 2025-09-13T08:01:36Z

Caution

Review failed

The pull request is closed.

Walkthrough

Refactors chat message rendering to use engine-provided messages via a new MessageList, simplifies streaming UI, and adjusts message-content styling. Updates tool-call control flow to push results via a callback. Bumps ai and @ai-sdk/react dependencies in multiple packages. No public UI component signatures changed; one tools API signature updated.

Changes

Cohort / File(s)	Summary
Dependency bumps `apps/web/client/package.json`, `packages/ai/package.json`, `packages/models/package.json`	Updated @ai-sdk/react 2.0.25→2.0.44 and ai 5.0.26→5.0.44 (including devDependency). No code changes.
Chat rendering refactor `apps/web/client/src/app/project/[id]/_components/right-panel/chat-tab/chat-messages/index.tsx`, `.../chat-messages/message-list.tsx`, `.../chat-messages/stream-message.tsx`	Switched rendering to engine messages; introduced `MessageList`; removed role-based per-message switch; simplified stream handling and loading UI; eliminated duplicate streaming message filtering from parent; adjusted keys.
Message content styling `.../chat-messages/message-content/index.tsx`	Added conditional overflow via `cn(...)`; applied compact styles to Markdown in reasoning block; behavior unchanged aside from styling under non-stream.
Tool-call flow update `apps/web/client/src/app/project/[id]/_hooks/use-chat.tsx`, `apps/web/client/src/components/tools/tools.ts`	`handleToolCall` now non-async, accepts optional `addToolResult` callback; `use-chat` passes callback and no longer awaits result; success/error results emitted via callback.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant ChatUI as Chat UI
  participant Engine as EditorEngine
  participant Tools as handleToolCall
  participant ChatStore as chat.addToolResult

  User->>ChatUI: Triggers tool call
  ChatUI->>Engine: Prepare toolCall
  ChatUI->>Tools: handleToolCall(toolCall, Engine, addToolResult)
  note right of Tools: Executes async internally
  Tools-->>ChatStore: addToolResult({ toolCallId, result | error })
  ChatStore-->>ChatUI: State updates (message with tool result)
  ChatUI-->>User: Renders updated messages

sequenceDiagram
  autonumber
  participant Engine as EditorEngine.chat.conversation
  participant ChatList as MessageList
  participant Stream as StreamMessage
  participant View as ChatMessages

  Engine-->>View: messages
  View->>ChatList: Render with engine messages
  alt Waiting (streaming)
    Stream-->>View: isWaiting=true, streamMessage
    Note over Stream,View: Show single "Thinking ..." indicator
  end
  ChatList-->>View: Render mapped user/assistant messages

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

feat: update ai sdk from v4 to v5 #2718 — Also updates AI SDK packages and adjusts chat message components and handleToolCall signature, indicating overlapping refactors.

Poem

In cables of chat where the messages stream,
I nibble the logs with a byte-sized beam.
Tools hop results with a callback’s grace,
Engine now leads in the rendering race.
Versions bumped, whiskers twitch—so neat!
Thump-thump: shipped changes, carrot-complete. 🥕🐇

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch bugs/gpt-5-rendering

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5f1c5fe and 137e519.

⛔ Files ignored due to path filters (1)

bun.lock is excluded by !**/*.lock

📒 Files selected for processing (9)

apps/web/client/package.json (2 hunks)
apps/web/client/src/app/project/[id]/_components/right-panel/chat-tab/chat-messages/index.tsx (3 hunks)
apps/web/client/src/app/project/[id]/_components/right-panel/chat-tab/chat-messages/message-content/index.tsx (2 hunks)
apps/web/client/src/app/project/[id]/_components/right-panel/chat-tab/chat-messages/message-list.tsx (1 hunks)
apps/web/client/src/app/project/[id]/_components/right-panel/chat-tab/chat-messages/stream-message.tsx (2 hunks)
apps/web/client/src/app/project/[id]/_hooks/use-chat.tsx (1 hunks)
apps/web/client/src/components/tools/tools.ts (1 hunks)
packages/ai/package.json (1 hunks)
packages/models/package.json (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

graphite-app · 2025-09-13T08:04:37Z

apps/web/client/src/components/tools/tools.ts

-        console.error('Error handling tool call', error);
-        return 'error handling tool call ' + error;
-    }
+    executeToolCall();


Critical bug: executeToolCall() is called without await, causing the function to return undefined instead of the tool result. This breaks the tool execution flow and will cause runtime errors when the result is expected. Change to: return executeToolCall(); or return await executeToolCall();

Suggested change

executeToolCall();

return executeToolCall();

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

This reverts commit 740ec31.

clean up

137e519

vercel bot deployed to Preview – docs September 13, 2025 08:01 View deployment

Kitenite merged commit 740ec31 into main Sep 13, 2025
4 of 6 checks passed

Kitenite deleted the bugs/gpt-5-rendering branch September 13, 2025 08:02

graphite-app bot reviewed Sep 13, 2025

View reviewed changes

vercel bot deployed to Preview – web September 13, 2025 08:04 View deployment

Kitenite added a commit that referenced this pull request Sep 13, 2025

Revert "fix: some gpt-5 stuttering (#2836)"

2491d5f

This reverts commit 740ec31.

Kitenite mentioned this pull request Sep 13, 2025

Revert "fix: some gpt-5 stutter" #2837

Merged

Kitenite added a commit that referenced this pull request Sep 13, 2025

Revert "fix: some gpt-5 stuttering (#2836)" (#2837)

55b10ad

This reverts commit 740ec31.

coderabbitai bot mentioned this pull request Oct 13, 2025

fix: scroll messages to bottom when sending #2997

Merged

5 tasks

coderabbitai bot mentioned this pull request Oct 20, 2025

Fix performance of chat panel during streaming #3020

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: some gpt-5 stutter #2836

fix: some gpt-5 stutter #2836

Uh oh!

Kitenite commented Sep 13, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Sep 13, 2025 •

edited

Loading

Uh oh!

supabase bot commented Sep 13, 2025

Uh oh!

coderabbitai bot commented Sep 13, 2025 •

edited

Loading

Review failed

Uh oh!

Uh oh!

graphite-app bot Sep 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: some gpt-5 stutter #2836

fix: some gpt-5 stutter #2836

Uh oh!

Conversation

Kitenite commented Sep 13, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Type of Change

Testing

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

Uh oh!

vercel bot commented Sep 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

supabase bot commented Sep 13, 2025

Uh oh!

coderabbitai bot commented Sep 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

Uh oh!

graphite-app bot Sep 13, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Kitenite commented Sep 13, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Sep 13, 2025 •

edited

Loading

coderabbitai bot commented Sep 13, 2025 •

edited

Loading