feat: branching clean #2767
Closed
feat: branching clean #2767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Caution Review failedThe pull request is closed. WalkthroughLarge refactor and API alignment: replace WebFrame/WebFrameView with Frame/FrameView across client/editor; rename many DB mappers to fromDb*/toDb*; add branch domain (models, schema, mappers, router, client BranchManager); add canvas/frame/chat/deployment DB schemas and related API changes; move project tags into metadata. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant UI as Client UI (Editor)
participant BM as BranchManager
participant API as tRPC branchRouter
participant DB as Database
User->>UI: Select/switch branch
UI->>BM: switchToBranch(branchId)
BM->>BM: set currentBranch (if changed)
alt starting sandbox
UI->>BM: startCurrentBranchSandbox()
BM->>API: getByProjectId(projectId)
API->>DB: SELECT branches WHERE projectId
DB-->>API: Branch[]
API-->>BM: fromDbBranch[] (mapped)
BM->>BM: getCurrentSandbox().start()
end
sequenceDiagram
autonumber
participant Client as Client (Frame create/update)
participant Store as FramesManager
participant API as frameRouter
participant DB as Database
Client->>Store: create/update Frame (Frame object)
Store->>API: create/update(input: frameInsert/UpdateSchema with id)
API->>DB: INSERT/UPDATE frames USING payload (uses id when updating)
DB-->>API: returning row
API-->>Store: fromDbFrame(dbRow)
Store->>Client: updated Frame
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (61)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| await ctx.db.insert(branches).values(input); | ||
| return true; | ||
| } catch (error) { | ||
| console.error('Error creating frame', error); |
Contributor
There was a problem hiding this comment.
Typographical error: The error message says 'Error creating frame', but given the context it should probably be 'Error creating branch'.
Suggested change
| console.error('Error creating frame', error); | |
| console.error('Error creating branch', error); |
| ); | ||
| return true; | ||
| } catch (error) { | ||
| console.error('Error updating frame', error); |
Contributor
There was a problem hiding this comment.
Typographical error: 'Error updating frame' should likely be 'Error updating branch'.
Suggested change
| console.error('Error updating frame', error); | |
| console.error('Error updating branch', error); |
| await ctx.db.delete(branches).where(eq(branches.id, input.branchId)); | ||
| return true; | ||
| } catch (error) { | ||
| console.error('Error deleting frame', error); |
Contributor
There was a problem hiding this comment.
Typographical error: 'Error deleting frame' should likely be 'Error deleting branch'.
Suggested change
| console.error('Error deleting frame', error); | |
| console.error('Error deleting branch', error); |
| import { createInsertSchema, createUpdateSchema } from "drizzle-zod"; | ||
| import { z } from "zod"; | ||
| import { projects } from "../project"; | ||
| import { CONVERSATION_MESSAGe_RELATION_NAME, messages } from "./message"; |
Contributor
There was a problem hiding this comment.
Typographical issue: The import name 'CONVERSATION_MESSAGe_RELATION_NAME' has an inconsistent casing. Likely, it should be 'CONVERSATION_MESSAGE_RELATION_NAME' with an uppercase 'E' to maintain consistency.
Suggested change
| import { CONVERSATION_MESSAGe_RELATION_NAME, messages } from "./message"; | |
| import { CONVERSATION_MESSAGE_RELATION_NAME, messages } from "./message"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Type of Change
Testing
Screenshots (if applicable)
Additional Notes
Important
Refactor codebase to introduce branch management, update models and mappers, refactor components, and enhance API routers.
BranchManagerclass inmanager.tsfor handling branch operations.Frame,Canvas,Branch, andProjectmodels inmodels/src/project.mappers/projectandmappers/chatto use new model structures.GestureScreen,FrameView,PageSelector,TopBar, andFrameComponentto use updated models.SelectProjectandSettingscomponents to handle new project metadata structure.branchRouterto handle branch-related API requests.conversationRouter,messageRouter,frameRouter, andprojectRouterto use new mappers.schema/canvas,schema/chat, andschema/project.defaults/frame.ts.This description was created by
for fbc13e6. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit