-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: mastra no storage #2650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: mastra no storage #2650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| }); | ||
| return this.generateStreamMessages(); | ||
| this.createAndAttachCommitToUserMessage(userMessage.id, content); |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The call to createAndAttachCommitToUserMessage is not awaited. While this matches the previous promise‐chain approach, consider awaiting it or adding error handling to prevent silent failures.
Suggested change
| this.createAndAttachCommitToUserMessage(userMessage.id, content); | |
| await this.createAndAttachCommitToUserMessage(userMessage.id, content); |
Closed
zongkelong
pushed a commit
to zongkelong/ulook
that referenced
this pull request
Aug 15, 2025
* 'main' of https://github.com/onlook-dev/onlook: (41 commits) feat: fix delete project (onlook-dev#2683) feat: reduce search latency (onlook-dev#2682) feat: revamp projects ux (onlook-dev#2672) Upload fix (onlook-dev#2677) feat: using firecrawl to screenshot (onlook-dev#2665) fix: file upload build error (onlook-dev#2674) feat: new project frames (onlook-dev#2673) feat: self hosting docs (onlook-dev#2671) fix: docs layout + troubleshoot section (onlook-dev#2670) fix(template): suppress hydration mismatch Feat/editor improvements (onlook-dev#2601) fix: make message content selectable (onlook-dev#2664) bugs: transient stream error (onlook-dev#2663) feat: update migration files (onlook-dev#2659) Start from Blank + Import buttons on the home page (onlook-dev#2653) fix: snapshot type conflict and mastra can't view image (onlook-dev#2656) fix: typecheck snapshot (onlook-dev#2655) feat: clean up mastra branch (onlook-dev#2654) feat: mastra no storage (onlook-dev#2650) feat: update ai packages (onlook-dev#2648) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Type of Change
Testing
Screenshots (if applicable)
Additional Notes
Important
Integrates Mastra for memory management, refines message handling and conversion, and updates models and tests in AI and DB packages.
Mastrafor memory and storage management inaianddbpackages.initModel()inproviders.tsto handleOPENROUTER_MODELS.CLAUDE_4_SONNETwith specific provider options.getHydratedUserMessage()inprovider.tsto handle message context and attachments.convertToStreamMessages()instream/index.tsfor convertingChatMessagetoCoreMessage.countTokensWithRoles()intokens/index.tsfor token counting in messages.ChatMessageandChatConversationinterfaces inmodelsto include metadata and context.toMessage()andfromMessage()indto/message.tsfor message conversion between DB and application models.MessageSnapshottype insnapshot.tsfor handling message snapshots.prompt,stream, andtokensfunctionalities inaipackage.convert.test.tsandtokens.test.ts.This description was created by
for 41f8581. You can customize this summary. It will automatically update as commits are pushed.