Skip to content

Conversation

@ilvalerione
Copy link

I added the ability to chain method when using removeParameter and addParameter in ParametersTrait returning $this.

Fluent api is yet available in setParameters method, but if you need to apply parameters by multiple call on addParameter you can't get advantage by methods chain.

@codecov-io
Copy link

codecov-io commented Jan 2, 2020

Codecov Report

❗ No coverage uploaded for pull request base (7.x@b86153c). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##             7.x     #304   +/-   ##
======================================
  Coverage       ?   78.46%           
  Complexity     ?      730           
======================================
  Files          ?      122           
  Lines          ?     1885           
  Branches       ?        0           
======================================
  Hits           ?     1479           
  Misses         ?      406           
  Partials       ?        0
Impacted Files Coverage Δ Complexity Δ
src/ParametersTrait.php 100% <100%> (ø) 8 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b86153c...a55b48d. Read the comment docs.

@saimaz saimaz changed the base branch from master to 6.x January 2, 2020 16:24
@saimaz saimaz changed the base branch from 6.x to 7.x January 2, 2020 16:26
@saimaz saimaz changed the base branch from 7.x to 6.x February 5, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants