Skip to content

Add nullable for size and from methods #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Add nullable for size and from methods #301

merged 1 commit into from
Dec 23, 2019

Conversation

PascalThesing
Copy link
Contributor

We are using static analyzing for our code and because of these not complete type hints, we get errors.

@codecov-io
Copy link

codecov-io commented Nov 20, 2019

Codecov Report

Merging #301 into 7.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                7.x     #301   +/-   ##
=========================================
  Coverage     78.49%   78.49%           
  Complexity      730      730           
=========================================
  Files           122      122           
  Lines          1883     1883           
=========================================
  Hits           1478     1478           
  Misses          405      405
Impacted Files Coverage Δ Complexity Δ
src/Search.php 22.6% <ø> (ø) 56 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71876a7...442d95f. Read the comment docs.

@saimaz saimaz merged commit 323d508 into ongr-io:7.x Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants