add ChainID field to CollectionGuarantee #1613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterargue
reviewed
Jul 28, 2025
jordanschalm
approved these changes
Jul 28, 2025
peterargue
reviewed
Jul 28, 2025
peterargue
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
ChainIDfield of CollectionGuarantees to the exported gRPC API and REST API (renamed tocluster_chain_id, to avoid confusion with the chain ID of the main network).This is so that the ID of a CollectionGuarantee (and therefore integrity of the chain) can be calculated by users of the API (notably, Rosetta) after the Malleability changes, required by onflow/flow-go#7630
For contributor use:
masterbranchFiles changedin the Github PR explorer