[WIP][Immutable Models M2] messages.Proposal, messages.ClusterProposal: message/internal split + validation #7731
+461
−224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lemented ToInternal func. Updated internal engines
… and messages.ClusterProposal for message hubs
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This was
linked to
issues
Aug 18, 2025
…b.com:onflow/flow-go into UlianaAndrukhiv/7698-block-proposal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is in progress. Please do not review.
This PR should be to
andron/7696-define-UntrustedMessage-interfacebranchand PR includes TODO which should be implemented when interface
UntrustedMessagewill be ready.Closes: #7698, #7701
Context
messages.Proposalandmessages.ClusterProposaltypes (typedef toflow.UntrustedProposalandcluster.UntrustedProposal).ToInternal()for them to convert to internal model.flow.UntrustedProposal/cluster.UntrustedProposaltomessages.Proposal/messages.ClusterProposalwhere do not used internally to be consistent.