-
Notifications
You must be signed in to change notification settings - Fork 195
collection/rpc: convert RPC engine to component.Component #7726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
collection/rpc: convert RPC engine to component.Component #7726
Conversation
…entManager workers (serve + shutdown); preserve metrics and rate limiting Co-Authored-By: peter.argue@flowfoundation.org <peter.argue@flowfoundation.org>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Co-Authored-By: peter.argue@flowfoundation.org <peter.argue@flowfoundation.org>
engine/collection/rpc/engine.go
Outdated
e.log.Err(err).Msg("failed to start server") | ||
ctx.Throw(err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.log.Err(err).Msg("failed to start server") | |
ctx.Throw(err) | |
ctx.Throw(fmt.Errorf("failed to start server: %w", err)) |
engine/collection/rpc/engine.go
Outdated
e.log.Error().Err(err).Msg("fatal error in server") | ||
ctx.Throw(err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.log.Error().Err(err).Msg("fatal error in server") | |
ctx.Throw(err) | |
ctx.Throw(fmt.Errorf("error encountered while running grpc server: %w", err)) |
Co-Authored-By: peter.argue@flowfoundation.org <peter.argue@flowfoundation.org>
collection/rpc: convert RPC engine to component.Component
Summary
Readiness semantics
Links and attribution
Verification
Notes