Update build workflow to support GitHub App #7350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7350 +/- ##
=======================================
Coverage 41.22% 41.22%
=======================================
Files 2199 2199
Lines 192119 192119
=======================================
+ Hits 79193 79194 +1
Misses 106325 106325
+ Partials 6601 6600 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sjonpaulbrown
force-pushed
the
sre/jp/309/update-build-workflow
branch
from
84a048f to
7284f88
Compare
peterargue
approved these changes
Apr 29, 2025
jordanschalm
approved these changes
Apr 30, 2025
janezpodhostnik
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
image_builds.ymlworkflow to use a GitHub App for authentication instead of a personal access token.Changes
actions/create-github-app-token@v2to generate a GitHub App token.secrets.SECURE_BUILDS_TOKENwith${{ steps.app-token.outputs.token }}.Motivation
Improves security and flexibility by using short-lived tokens and granular permissions.
Example Runs