Update to and enable EVM Pectra hard-fork #7328
Conversation
m-Peter
requested review from
janezpodhostnik,
zhangchiqing and
a team
as code owners
| func (db *StateDB) SetNonce( | ||
| addr gethCommon.Address, | ||
| nonce uint64, | ||
| reason gethTracing.NonceChangeReason, |
There was a problem hiding this comment.
For some reason, the Geth folks introduced this gethTracing.NonceChangeReason function parameter, but it's not used anywhere within the method's body.
See: https://github.com/ethereum/go-ethereum/blob/v1.15.8/core/state/statedb.go#L435-L440
| // This is a no-op for our custom implementation of the StateDB interface, | ||
| // since Commit() already handles finalization and deletion of empty | ||
| // objects. | ||
| func (db *StateDB) Finalise(deleteEmptyObjects bool) {} |
There was a problem hiding this comment.
This is a no-op in our case, because our custom implementation of StateDB, already handles the finalization and deletion of empty objects as part of Commit .
| castedValue, | ||
| call.GasLimit) | ||
| call.GasLimit, | ||
| nil, |
There was a problem hiding this comment.
For the deployment of COAs, we pass nil for the jumpDests argument, as it is not exposed through the EVM object. See also:
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7328 +/- ##
=======================================
Coverage 41.05% 41.05%
=======================================
Files 2203 2203
Lines 192973 193023 +50
=======================================
+ Hits 79224 79247 +23
- Misses 107145 107173 +28
+ Partials 6604 6603 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fvm/evm/emulator/config.go
Outdated
| @@ -17,6 +17,12 @@ var ( | |||
| bigZero = big.NewInt(0) | |||
| ) | |||
|
|
|||
| var ( | |||
| PreviewnetPragueActivation = uint64(0) // already on Prague for PreviewNet | |||
| TestnetPragueActivation = uint64(1746039600) // Wednesday, April 30, 2025 7:00:00 PM GMT | |||
There was a problem hiding this comment.
TODO(m-Peter): Update this once we decide on the time for the Pectra upgrade on Testnet.
There was a problem hiding this comment.
nit: I would put them far into the future until we know the exact time. So that if this accidentally merged we wont have problems.
fvm/evm/emulator/config.go
Outdated
| var ( | ||
| PreviewnetPragueActivation = uint64(0) // already on Prague for PreviewNet | ||
| TestnetPragueActivation = uint64(1746039600) // Wednesday, April 30, 2025 7:00:00 PM GMT | ||
| MainnetPragueActivation = uint64(1746612311) // Wed May 07 10:05:11 2025 UTC |
There was a problem hiding this comment.
TODO(m-Peter): Update this once we decide on the time for the Pectra upgrade on Mainnet.
fvm/evm/emulator/config.go
Outdated
| @@ -17,6 +17,12 @@ var ( | |||
| bigZero = big.NewInt(0) | |||
| ) | |||
|
|
|||
| var ( | |||
| PreviewnetPragueActivation = uint64(0) // already on Prague for PreviewNet | |||
| TestnetPragueActivation = uint64(1746039600) // Wednesday, April 30, 2025 7:00:00 PM GMT | |||
There was a problem hiding this comment.
nit: I would put them far into the future until we know the exact time. So that if this accidentally merged we wont have problems.
m-Peter
force-pushed
the
mpeter/pectra-upgrade
branch
from
911d156 to
59bc9e3
Compare
…abling it in case of emergency HCU
set Pectra upgrade timestamp to Jun 3rd 2025
Closes: #7152
Closes: #7227