[Storage] Remove old code in initBadgerDB()
#7230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, initProtocolDB() sets ProtocolDB to either BadgerDB or PebbleDB depending on dbops. But there is still some old code that sets ProtocolDB to BadgerDB in initBadgerDB(). This commit removes the old code in initBadgerDB().
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7230 +/- ##
==========================================
- Coverage 41.36% 41.36% -0.01%
==========================================
Files 2174 2174
Lines 190130 190127 -3
==========================================
- Hits 78651 78639 -12
- Misses 104898 104905 +7
- Partials 6581 6583 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fxamacker
changed the title
initBadgerDB()initBadgerDB()
janezpodhostnik
approved these changes
Apr 4, 2025
zhangchiqing
approved these changes
Apr 4, 2025
fxamacker
deleted the
fxamacker/remove-old-code-to-set-protocoldb-in-initBadgerDB
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #6527
Currently,
initProtocolDB()setsProtocolDBto either BadgerDB or PebbleDB depending ondbops. But there is still some old code that setsProtocolDBto BadgerDB ininitBadgerDB().This PR removes the old code in
initBadgerDB().I found this while getting familiar with storage code releated to BadgerDB and Pebble.