Skip to content

Add string function to StateCommitment type, use in place of marshalJSON #7194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

Kay-Zee
Copy link
Member

@Kay-Zee Kay-Zee commented Mar 26, 2025

Closes #7193

while building the block model for the rest api, we shouldn't manually call marshalJSON, as that will actually double encode this particular value. Instead, just add string function to the type and call that instead

@Kay-Zee Kay-Zee self-assigned this Mar 26, 2025
@Kay-Zee Kay-Zee requested a review from a team as a code owner March 26, 2025 20:55
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 41.36%. Comparing base (02b0c42) to head (20b5df2).

Files with missing lines Patch % Lines
model/flow/ledger.go 0.00% 3 Missing ⚠️
engine/access/rest/common/models/block.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7194      +/-   ##
==========================================
- Coverage   41.38%   41.36%   -0.02%     
==========================================
  Files        2174     2174              
  Lines      190130   190126       -4     
==========================================
- Hits        78691    78654      -37     
- Misses     104863   104890      +27     
- Partials     6576     6582       +6     
Flag Coverage Δ
unittests 41.36% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kay-Zee Kay-Zee added this pull request to the merge queue Apr 10, 2025
Merged via the queue into master with commit aed1389 Apr 10, 2025
56 checks passed
@Kay-Zee Kay-Zee deleted the kan/7193-remove-double-encoded-final-state-rest-api branch April 10, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data Availability] Double encoded final state hash on rest API
4 participants