[BFT] model.Proposal refactoring
#6526
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otstuff proposal. Updated SafetyRules interface and implementation
…/6517-proposal-refactoring
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6526 +/- ##
==========================================
- Coverage 41.27% 41.15% -0.13%
==========================================
Files 2030 2031 +1
Lines 145822 179602 +33780
==========================================
+ Hits 60186 73912 +13726
- Misses 79419 99491 +20072
+ Partials 6217 6199 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jordanschalm
approved these changes
Oct 3, 2024
Co-authored-by: Jordan Schalm <jordan.schalm@flowfoundation.org>
AlexHentschel
approved these changes
Oct 19, 2024
| // This codifies the important aspect that a proposer's signature for their own block | ||
| // is conceptually also just a vote (we explicitly use that for aggregating votes, including the | ||
| // proposer's own vote to a QC). In order to express this conceptual equivalence in code, the | ||
| // voting logic in Safety Rules must also operate on an unsigned Proposal. | ||
| type Proposal struct { |
There was a problem hiding this comment.
Suggested change
| type Proposal struct { | |
| // | |
| // NOTE: LastViewTC is auxiliary data that must accompany a pending proposal until it is | |
| // certified. Atm, we include LastViewTC in the `flow.Header` but that is not strictly needed. | |
| // Conceptually, LastViewTC is only needed to prove that the proposer entered the block's view | |
| // according to protocol rules. Thereby we protect the consensus process from malicious leaders | |
| // attempting to skip views that haven't concluded yet (a form of front-running attack). | |
| // However, the LastViewTC is only relevant until a proposed block has been certified. | |
| // Thereafter, the QC attests that honest consensus participants have inspected the LastViewTC | |
| // and found it to be valid. At that point, the LastViewTC is no longer needed. Therefore, | |
| // the LastViewTC is auxiliary data that must accompany a pending proposal until it is | |
| // certified but LastViewTC does not need to be part of the block itself. | |
| // | |
| // TODO: atm, the flow.Header embeds the LastViewTC and also includes it when computing the | |
| // block's ID. This is simpler from an implementation perspective, but the LastViewTC wastes | |
| // some communication bandwidth when relaying certified blocks to the consensus followers. | |
| type Proposal struct { |
consensus/hotstuff/votecollector/combined_vote_processor_v3_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Hentschel <alex.hentschel@flowfoundation.org>
Co-authored-by: Alexander Hentschel <alex.hentschel@flowfoundation.org>
…st.go Co-authored-by: Alexander Hentschel <alex.hentschel@flowfoundation.org>
…onflow/flow-go into yurii/6517-proposal-refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6517
Context
This PR implements refactoring of
model.Proposal, all details are in attached issue. This PR very closes follows proposed solution.