Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport v0.37 [Bootstrap] Fix duplication detection in root block finalization #6485

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

zhangchiqing
Copy link
Member

Backport #6484

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 43.75000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 41.43%. Comparing base (ae4ce43) to head (c245fd9).
Report is 80 commits behind head on v0.37.

Files with missing lines Patch % Lines
cmd/bootstrap/cmd/final_list.go 0.00% 4 Missing ⚠️
cmd/bootstrap/cmd/finalize.go 66.66% 2 Missing and 1 partial ⚠️
cmd/bootstrap/cmd/rootblock.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            v0.37    #6485   +/-   ##
=======================================
  Coverage   41.43%   41.43%           
=======================================
  Files        2017     2017           
  Lines      144019   144057   +38     
=======================================
+ Hits        59678    59694   +16     
- Misses      78137    78153   +16     
- Partials     6204     6210    +6     
Flag Coverage Δ
unittests 41.43% <43.75%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AlexHentschel AlexHentschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the backport

@zhangchiqing zhangchiqing merged commit c0377f2 into v0.37 Oct 1, 2024
55 checks passed
@zhangchiqing zhangchiqing deleted the leo/v0.37-fix-finalization branch October 1, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants