Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.37] Transaction Validator recovers from script parse panic #6443

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

jordanschalm
Copy link
Member

@jordanschalm jordanschalm commented Sep 6, 2024

Backport #6435

In some cases, the Cadence parser can panic rather than return an error. This PR changes the TransactionValidator -- which attempts to parse scripts as part of transaction validation -- to recover from such panics and return the recovered error.

See: https://github.com/dapperlabs/flow-go/issues/6964 and onflow/cadence#3428

@zhangchiqing zhangchiqing changed the base branch from master to v0.37 September 6, 2024 16:35
@jordanschalm jordanschalm changed the title [v0.37] Transaction Validator recovers from script parse panic [v0.27] Transaction Validator recovers from script parse panic Sep 6, 2024
@jordanschalm jordanschalm changed the title [v0.27] Transaction Validator recovers from script parse panic [v0.37] Transaction Validator recovers from script parse panic Sep 6, 2024
@jordanschalm jordanschalm merged commit 3ae829d into v0.37 Sep 6, 2024
@jordanschalm jordanschalm deleted the jord/v0.37/script-parse-recover branch September 6, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants