Cleanup streaming errors for block not ready

[AndriiDiachuk]

Closes: #5574

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.45%. Comparing base (ad12394) to head (b1471c5).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5632      +/-   ##
==========================================
- Coverage   55.55%   55.45%   -0.11%     
==========================================
  Files        1043      991      -52     
  Lines      102034    97588    -4446     
==========================================
- Hits        56689    54113    -2576     
+ Misses      40992    39250    -1742     
+ Partials     4353     4225     -128     

Flag	Coverage Δ
unittests	55.45% <100.00%> (-0.11%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[peterargue]

good start. I think there are a few more places to update as well.

we're looking to simplify this list in the streamer:

flow-go/engine/access/subscription/streamer.go

Lines 108 to 114 in ad12394

	if errors.Is(err, storage.ErrNotFound) ||
	errors.Is(err, storage.ErrHeightNotIndexed) ||
	execution_data.IsBlobNotFoundError(err) ||
	errors.Is(err, ErrBlockNotReady) {
	// no more available
	return nil
	}

to just be

if errors.Is(err, ErrBlockNotReady) {
	return nil
}

So all code that returns errors to subscription.Next will need to have updated error handling that converts one those errors into subscription.ErrBlockNotReady. Other errors can be returned normally so they get handled as they do today.

[peterargue]

please also update the other streaming endpoints in a similar way

[peterargue]

please also update

flow-go/engine/access/subscription/streamer.go

Lines 108 to 114 in ad12394

	if errors.Is(err, storage.ErrNotFound) ||
	errors.Is(err, storage.ErrHeightNotIndexed) ||
	execution_data.IsBlobNotFoundError(err) ||
	errors.Is(err, ErrBlockNotReady) {
	// no more available
	return nil
	}

to only match on subscription.ErrBlockNotReady

[Guitarheroua]

I added a couple of small comments. Otherwise, it looks good!