Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] improve handler #5516

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Conversation

ramtinms
Copy link
Member

@ramtinms ramtinms commented Mar 6, 2024

This PR updates the handler to check for the condition of direct message failure during deposit and withdrawal calls. This condition right now is impossible but checks have been added as extra safe guards in case of future changes break this assumption.

@ramtinms ramtinms requested a review from sideninja March 6, 2024 03:17
@ramtinms ramtinms marked this pull request as ready for review March 6, 2024 03:17
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 55.86%. Comparing base (bd1722d) to head (333b13d).

Files Patch % Lines
fvm/evm/handler/handler.go 30.76% 12 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5516      +/-   ##
==========================================
- Coverage   55.86%   55.86%   -0.01%     
==========================================
  Files        1030     1030              
  Lines      100822   100843      +21     
==========================================
+ Hits        56329    56332       +3     
- Misses      40164    40177      +13     
- Partials     4329     4334       +5     
Flag Coverage Δ
unittests 55.86% <30.76%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sideninja sideninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

Copy link
Contributor

@janezpodhostnik janezpodhostnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice extra check.

@ramtinms ramtinms enabled auto-merge March 6, 2024 19:01
@ramtinms ramtinms added this pull request to the merge queue Mar 6, 2024
Merged via the queue into master with commit 19d31c7 Mar 6, 2024
55 checks passed
@ramtinms ramtinms deleted the ramtin/flow-evm-improve-handler branch March 6, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants