[Flow EVM] Fix the evm chainID bug for mainnet #5443
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5443 +/- ##
==========================================
- Coverage 55.84% 55.83% -0.01%
==========================================
Files 1029 1030 +1
Lines 100798 100807 +9
==========================================
- Hits 56291 56289 -2
- Misses 40179 40186 +7
- Partials 4328 4332 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ramtinms
changed the title
| ) | ||
|
|
||
| var ( | ||
| FlowEVMTestnetChainID = big.NewInt(646) |
There was a problem hiding this comment.
nit: why is Flow in the name, wouldn't this just be EVMTestnetID and EVMMainnetID
There was a problem hiding this comment.
We could name it EVMTestnetID , I used the Flow in case someone externally is using it and we use name FlowEVM for the evm chain
| // WithMainnetChainID sets the chain ID to flow evm testnet | ||
| func WithTestnetChainID() Option { | ||
| // WithChainID sets the evm chain ID | ||
| func WithChainID(chainID *big.Int) Option { |
There was a problem hiding this comment.
could we make this a type instead of *big.Int
| ) | ||
|
|
||
| var ( | ||
| FlowEVMTestnetChainID = big.NewInt(646) |
There was a problem hiding this comment.
same as above: could this be
type EVMChainID big.Int
There was a problem hiding this comment.
I start with that change first but we directly use this value for a lot of internal EVM stuff that needs the big.Int value and there was a couple of typecasting that we had to do. I might revisit this later
ramtinms
deleted the
ramtin/5441-use-evm-mainnet-chainID-for-flow-mainnet
branch
closes: #5441