Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Revert change to use semver build for without-netgo images #5267

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

peterargue
Copy link
Contributor

Revert #5157. The change to without-netgo image tags is not compliant with the docker tag format

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f496a55) 55.56% compared to head (1ba5e34) 49.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5267      +/-   ##
==========================================
- Coverage   55.56%   49.02%   -6.54%     
==========================================
  Files         995      177     -818     
  Lines       95383    15202   -80181     
==========================================
- Hits        52997     7453   -45544     
+ Misses      38405     7241   -31164     
+ Partials     3981      508    -3473     
Flag Coverage Δ
unittests 49.02% <ø> (-6.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterargue peterargue added this pull request to the merge queue Jan 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2024
@peterargue peterargue added this pull request to the merge queue Jan 22, 2024
Merged via the queue into master with commit 82a344e Jan 22, 2024
51 checks passed
@peterargue peterargue deleted the petera/revert-withoutnetgo-tag-name branch January 22, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants