-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EVM] Add feature flag for deploying EVM
contract only with ABI functionality
#5230
[EVM] Add feature flag for deploying EVM
contract only with ABI functionality
#5230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
fvm/bootstrap.go
Outdated
@@ -77,6 +77,7 @@ type BootstrapParams struct { | |||
storagePerFlow cadence.UFix64 | |||
restrictedAccountCreationEnabled cadence.Bool | |||
setupEVMEnabled cadence.Bool | |||
evmAbiOnly cadence.Bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given this is just a feature flag and the value is only used in Go / not passed to Cadence, this can just be a plain bool
(and usages below as well)
evmAbiOnly cadence.Bool | |
evmAbiOnly bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was wondering about it as well, but it seems that every config is a Cadence value. Not sure why.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5230 +/- ##
==========================================
+ Coverage 55.60% 55.61% +0.01%
==========================================
Files 995 995
Lines 95475 95485 +10
==========================================
+ Hits 53088 53105 +17
+ Misses 38413 38408 -5
+ Partials 3974 3972 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a21a51b
to
b2a489c
Compare
EVM
contract only with ABI functionalityEVM
contract only with ABI functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me, though I recommend waiting for the setup fixes by @janezpodhostnik to be merged first and then we merge this PR.
b2a489c
to
37381bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e43174f
to
a989313
Compare
Adds the relevant config options and contract code, for deploying the
EVM
contract with only the necessary functionality forABI
encoding/decoding:EVM.encodeABI
EVM.decodeABI
EVM.encodeABIWithSignature
EVM.decodeABIWithSignature
The
EVM.EVMAddress
type is also included in the minifiedEVM
contract, as it is required for encoding/decoding to the Solidityaddress
type.