Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Use local event for event streaming API #5160

Merged
merged 6 commits into from
Dec 22, 2023

Conversation

peterargue
Copy link
Contributor

Closes: #4852

Use locally indexed events for Event streaming API

@peterargue peterargue changed the base branch from master to petera/4751-use-local-events December 19, 2023 16:31
@peterargue peterargue changed the title [Access] Use local event for AccessAPI get events endpoints [Access] Use local event for event streaming API Dec 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (a1b17ac) 56.48% compared to head (b019298) 56.46%.

Files Patch % Lines
...gine/access/state_stream/backend/backend_events.go 75.00% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5160      +/-   ##
==========================================
- Coverage   56.48%   56.46%   -0.02%     
==========================================
  Files         981      981              
  Lines       93127    93154      +27     
==========================================
+ Hits        52602    52604       +2     
- Misses      36632    36653      +21     
- Partials     3893     3897       +4     
Flag Coverage Δ
unittests 56.46% <76.74%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterargue peterargue force-pushed the petera/4852-use-local-event-streaming2 branch from 960ae23 to 2ac857e Compare December 22, 2023 16:37
@peterargue peterargue self-assigned this Dec 22, 2023
Base automatically changed from petera/4751-use-local-events to master December 22, 2023 17:15
@peterargue peterargue added this pull request to the merge queue Dec 22, 2023
Merged via the queue into master with commit 92e6d16 Dec 22, 2023
51 checks passed
@peterargue peterargue deleted the petera/4852-use-local-event-streaming2 branch December 22, 2023 19:10
peterargue added a commit that referenced this pull request Jan 4, 2024
…aming2

[Access] Use local event for event streaming API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Use local index for Events in Event streaming API
4 participants