-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BFT] ReceiptValidator
ensures k
receipts committing to the execution result
#5050
Merged
durkmurder
merged 14 commits into
master
from
yurii/6863-receipt-validator-checks-number-of-receipts
Dec 19, 2023
Merged
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
77c274e
Added a constant for verifying how many execution receipts are needed…
durkmurder b76556e
Added implementation of checks that ensure that we have seen at least…
durkmurder e10d39b
Added new tests to cover happy and failure paths
durkmurder 39852c0
Added a flag for configuring new parameter. Fixed tests
durkmurder 86ae19a
Linted
durkmurder 04f0d1c
Simplified building of receipts by result index
durkmurder 9b0ba4c
Made k not configurable and always be equal to 1
durkmurder 856c8cc
Added back test for k > 1
durkmurder 2590981
Update module/validation/receipt_validator.go
durkmurder fc664cf
Merge branch 'master' into yurii/6863-receipt-validator-checks-number…
durkmurder 103de18
Merge branch 'master' into yurii/6863-receipt-validator-checks-number…
durkmurder b35446d
Merge branch 'master' into yurii/6863-receipt-validator-checks-number…
durkmurder ca26248
Apply suggestions from PR review
durkmurder d99b7b9
Merge branch 'master' into yurii/6863-receipt-validator-checks-number…
durkmurder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this function
ValidatePayload
, we are checking the protocol compliance of all the results in the payload. Anything that violates protocol rules makes the entire block invalid. I think arguing at that level is totally fine. I don't think we need to go into the details of parent-children relationship (tbh, I didn't follow that argument about parent-children relationship ... it might have well been me adding or suggesting this comment).