Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Testing] Add BuildJet CI runners for unit tests, integration tests; cache Docker images - backport #5015

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

peterargue
Copy link
Contributor

Backports: #4906

[CI][Testing] Add BuildJet CI runners for unit tests, integration tests; cache Docker images
@peterargue peterargue self-assigned this Nov 14, 2023
@peterargue
Copy link
Contributor Author

The Epoch Cohort2 test keeps failing, so I'm guessing there are some changes missing. @jordanschalm are you aware of any change on master that may affect them? backporting this will make the v0.32 tests less flaky

@jordanschalm
Copy link
Member

jordanschalm commented Nov 29, 2023

Probably this one: #4975

Backporting VN epoch test flakiness fix from master
@jordanschalm
Copy link
Member

@peterargue I cherry-picked #4975 into this branch, in this commit: 9c4f2c3. That should resolve the flaky test 🤞

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4805471) 55.84% compared to head (9c4f2c3) 57.23%.
Report is 19 commits behind head on v0.32.

Files Patch % Lines
utils/test_matrix/test_matrix.go 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            v0.32    #5015      +/-   ##
==========================================
+ Coverage   55.84%   57.23%   +1.38%     
==========================================
  Files         945      759     -186     
  Lines       88208    71988   -16220     
==========================================
- Hits        49257    41199    -8058     
+ Misses      35241    27660    -7581     
+ Partials     3710     3129     -581     
Flag Coverage Δ
unittests 57.23% <96.66%> (+1.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterargue
Copy link
Contributor Author

@peterargue I cherry-picked #4975 into this branch, in this commit: 9c4f2c3. That should resolve the flaky test 🤞

thanks!

@peterargue peterargue merged commit de2050d into v0.32 Nov 29, 2023
54 checks passed
@peterargue peterargue deleted the petera/backport-ci-changes branch November 29, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants