Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Networking] GossipSub Spam Mitigation- Dynamic Decay Speed #4891

Merged
merged 57 commits into from
Nov 29, 2023
Merged

[Networking] GossipSub Spam Mitigation- Dynamic Decay Speed #4891

merged 57 commits into from
Nov 29, 2023

Commits on Oct 26, 2023

  1. update initial spam record decay 

    - remove static decay of .99 instead initialize to random decay that is updated based on gossip score
- update tests ensure initial decay is between constant lower and upper bounds
    @kc1116
    kc1116 committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    b8b378b View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. add test for new decay adjustment 

    - add new GossipSubScoringRegistryConfig struct to hold configs needed for registry that were previously hard coded
- update builders
    @kc1116
    kc1116 committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    a454e9e View commit details
    Browse the repository at this point in the history

  2. add validation flag to ensure InitDecayUpperBound is greater than Ini… 

    …tDecayLowerBound
    @kc1116
    kc1116 committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    d291107 View commit details
    Browse the repository at this point in the history

  3. Update registry_test.go

    @kc1116
    kc1116 committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    95a7daf View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Update config/config_test.go 

    Co-authored-by: Misha <15269764+gomisha@users.noreply.github.com>
    @kc1116 @gomisha
    kc1116 and gomisha authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    89f5e4f View commit details
    Browse the repository at this point in the history

  2. Update network/p2p/scoring/registry_test.go 

    Co-authored-by: Misha <15269764+gomisha@users.noreply.github.com>
    @kc1116 @gomisha
    kc1116 and gomisha authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    acf5a2b View commit details
    Browse the repository at this point in the history

  3. Update network/p2p/scoring/scoring_test.go 

    Co-authored-by: Misha <15269764+gomisha@users.noreply.github.com>
    @kc1116 @gomisha
    kc1116 and gomisha authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    9b167db View commit details
    Browse the repository at this point in the history

  4. Update network/p2p/p2pbuilder/gossipsub/gossipSubBuilder.go 

    Co-authored-by: Misha <15269764+gomisha@users.noreply.github.com>
    @kc1116 @gomisha
    kc1116 and gomisha authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    d27a7ef View commit details
    Browse the repository at this point in the history

  5. Update network/p2p/p2pbuilder/libp2pNodeBuilder.go 

    Co-authored-by: Misha <15269764+gomisha@users.noreply.github.com>
    @kc1116 @gomisha
    kc1116 and gomisha authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    3515c95 View commit details
    Browse the repository at this point in the history

  6. Update network/p2p/p2pbuilder/libp2pNodeBuilder.go 

    Co-authored-by: Misha <15269764+gomisha@users.noreply.github.com>
    @kc1116 @gomisha
    kc1116 and gomisha authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    ad725a1 View commit details
    Browse the repository at this point in the history

  7. Update network/p2p/test/fixtures.go 

    Co-authored-by: Misha <15269764+gomisha@users.noreply.github.com>
    @kc1116 @gomisha
    kc1116 and gomisha authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    e8b04b1 View commit details
    Browse the repository at this point in the history

  8. use camel case

    @kc1116
    kc1116 committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    5d1dfbe View commit details
    Browse the repository at this point in the history

  9. Merge branch 'khalil/6662-peer-id-specific-decay' of github.com:onflo… 

    …w/flow-go into khalil/6662-peer-id-specific-decay
    @kc1116
    kc1116 committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    96a9976 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' of github.com:onflow/flow-go into khalil/6662-p… 

    …eer-id-specific-decay
    @kc1116
    kc1116 committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    4eac1ba View commit details
    Browse the repository at this point in the history

  11. use secure random

    @kc1116
    kc1116 committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    8b90530 View commit details
    Browse the repository at this point in the history

  12. Update registry.go

    @kc1116
    kc1116 committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    d21749f View commit details
    Browse the repository at this point in the history

  13. Merge branch 'master' into khalil/6662-peer-id-specific-decay

    @kc1116
    kc1116 authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    a8cb8f3 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Update network/p2p/scoring/registry.go 

    Co-authored-by: Yahya Hassanzadeh, Ph.D. <yhassanzadeh@ieee.org>
    @kc1116 @yhassanzadeh13
    kc1116 and yhassanzadeh13 authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    268f384 View commit details
    Browse the repository at this point in the history

  2. Update network/p2p/scoring/registry.go 

    Co-authored-by: Yahya Hassanzadeh, Ph.D. <yhassanzadeh@ieee.org>
    @kc1116 @yhassanzadeh13
    kc1116 and yhassanzadeh13 authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    d8bf4b5 View commit details
    Browse the repository at this point in the history

  3. revert changes to init spam record func

    @kc1116
    kc1116 committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    4892ccc View commit details
    Browse the repository at this point in the history

  4. Merge branch 'khalil/6662-peer-id-specific-decay' of github.com:onflo… 

    …w/flow-go into khalil/6662-peer-id-specific-decay
    @kc1116
    kc1116 committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    4971ee6 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. use config instead of params 

    - update config values and flags
    @kc1116
    kc1116 committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    5b9394e View commit details
    Browse the repository at this point in the history

  2. combine both decay pre-processing funcs into a single func 

    - add can adjust decay field to spam record
    @kc1116
    kc1116 committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    5c7bf31 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. update remote

    @kc1116
    kc1116 committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    6434b88 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. update scoring registry replace can adjust decay with decay adjust in… 

    …terval

- update registry tests and decay tests
- update flags and configs
    @kc1116
    kc1116 committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    fae328f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:onflow/flow-go into khalil/6662-p… 

    …eer-id-specific-decay
    @kc1116
    kc1116 committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    e282d6c View commit details
    Browse the repository at this point in the history

  3. fix lint

    @kc1116
    kc1116 committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    1cf963a View commit details
    Browse the repository at this point in the history

  4. update godoc

    @kc1116
    kc1116 committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    66b9644 View commit details
    Browse the repository at this point in the history

  5. update godoc

    @kc1116
    kc1116 committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    071b072 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'khalil/6662-peer-id-specific-decay' of github.com:onflo… 

    …w/flow-go into khalil/6662-peer-id-specific-decay
    @kc1116
    kc1116 committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    fe69da7 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. simplify node builder arguments

    @kc1116
    kc1116 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    f75f01d View commit details
    Browse the repository at this point in the history

  2. Update config/default-config.yml 

    Co-authored-by: Yahya Hassanzadeh, Ph.D. <yhassanzadeh@ieee.org>
    @kc1116 @yhassanzadeh13
    kc1116 and yhassanzadeh13 authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    2cb6c1d View commit details
    Browse the repository at this point in the history

  3. Update config/default-config.yml 

    Co-authored-by: Yahya Hassanzadeh, Ph.D. <yhassanzadeh@ieee.org>
    @kc1116 @yhassanzadeh13
    kc1116 and yhassanzadeh13 authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    a8d5bd0 View commit details
    Browse the repository at this point in the history

  4. Update config/default-config.yml 

    Co-authored-by: Yahya Hassanzadeh, Ph.D. <yhassanzadeh@ieee.org>
    @kc1116 @yhassanzadeh13
    kc1116 and yhassanzadeh13 authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    8973fac View commit details
    Browse the repository at this point in the history

  5. Merge branch 'khalil/6662-peer-id-specific-decay' of github.com:onflo… 

    …w/flow-go into khalil/6662-peer-id-specific-decay
    @kc1116
    kc1116 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    df0d214 View commit details
    Browse the repository at this point in the history

  6. update flags

    @kc1116
    kc1116 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    ec804cf View commit details
    Browse the repository at this point in the history

  7. Update config/default-config.yml 

    Co-authored-by: Yahya Hassanzadeh, Ph.D. <yhassanzadeh@ieee.org>
    @kc1116 @yhassanzadeh13
    kc1116 and yhassanzadeh13 authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    1e7374f View commit details
    Browse the repository at this point in the history

  8. Update config/default-config.yml 

    Co-authored-by: Yahya Hassanzadeh, Ph.D. <yhassanzadeh@ieee.org>
    @kc1116 @yhassanzadeh13
    kc1116 and yhassanzadeh13 authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    2865935 View commit details
    Browse the repository at this point in the history

  9. Update config/default-config.yml 

    Co-authored-by: Yahya Hassanzadeh, Ph.D. <yhassanzadeh@ieee.org>
    @kc1116 @yhassanzadeh13
    kc1116 and yhassanzadeh13 authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    ba1cc07 View commit details
    Browse the repository at this point in the history

  10. Update follower/follower_builder.go 

    Co-authored-by: Yahya Hassanzadeh, Ph.D. <yhassanzadeh@ieee.org>
    @kc1116 @yhassanzadeh13
    kc1116 and yhassanzadeh13 authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    e07c3e0 View commit details
    Browse the repository at this point in the history

  11. update flag descriptions

    @kc1116
    kc1116 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    5c2cce3 View commit details
    Browse the repository at this point in the history

  12. Update network/p2p/cache.go 

    Co-authored-by: Yahya Hassanzadeh, Ph.D. <yhassanzadeh@ieee.org>
    @kc1116 @yhassanzadeh13
    kc1116 and yhassanzadeh13 authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    349aaf2 View commit details
    Browse the repository at this point in the history

  13. remove gt=-100, validator

    @kc1116
    kc1116 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    7b08807 View commit details
    Browse the repository at this point in the history

  14. remove custom validator

    @kc1116
    kc1116 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    8816679 View commit details
    Browse the repository at this point in the history

  15. Update network/p2p/scoring/decay_test.go 

    Co-authored-by: Yahya Hassanzadeh, Ph.D. <yhassanzadeh@ieee.org>
    @kc1116 @yhassanzadeh13
    kc1116 and yhassanzadeh13 authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    b72cbce View commit details
    Browse the repository at this point in the history

  16. Update network/p2p/scoring/decay_test.go 

    Co-authored-by: Yahya Hassanzadeh, Ph.D. <yhassanzadeh@ieee.org>
    @kc1116 @yhassanzadeh13
    kc1116 and yhassanzadeh13 authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    70ae578 View commit details
    Browse the repository at this point in the history

  17. Update network/p2p/scoring/decay_test.go 

    Co-authored-by: Yahya Hassanzadeh, Ph.D. <yhassanzadeh@ieee.org>
    @kc1116 @yhassanzadeh13
    kc1116 and yhassanzadeh13 authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    689eb47 View commit details
    Browse the repository at this point in the history

  18. Update network/p2p/scoring/decay_test.go 

    Co-authored-by: Yahya Hassanzadeh, Ph.D. <yhassanzadeh@ieee.org>
    @kc1116 @yhassanzadeh13
    kc1116 and yhassanzadeh13 authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    9ee6388 View commit details
    Browse the repository at this point in the history

  19. Update network/p2p/test/fixtures.go 

    Co-authored-by: Yahya Hassanzadeh, Ph.D. <yhassanzadeh@ieee.org>
    @kc1116 @yhassanzadeh13
    kc1116 and yhassanzadeh13 authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    28ec6c4 View commit details
    Browse the repository at this point in the history

  20. rename MinimumSpamPenaltyDecaySpeed -> MinimumSpamPenaltyDecayFactor … 

    …& MaximumSpamPenaltyDecaySpeed -> MaximumSpamPenaltyDecayFactor
    @kc1116
    kc1116 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    9ae267f View commit details
    Browse the repository at this point in the history

  21. check peer application specific scores upon initialization

    @kc1116
    kc1116 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    640ef41 View commit details
    Browse the repository at this point in the history

  22. ensure peer score decay can be reduced again after recovering

    @kc1116
    kc1116 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    8885c1c View commit details
    Browse the repository at this point in the history

  23. Merge branch 'khalil/6662-peer-id-specific-decay' of github.com:onflo… 

    …w/flow-go into khalil/6662-peer-id-specific-decay
    @kc1116
    kc1116 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    33fc0c4 View commit details
    Browse the repository at this point in the history

  24. improve tests check decay value on each callback iteration

    @kc1116
    kc1116 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    eafd434 View commit details
    Browse the repository at this point in the history

  25. Merge branch 'master' into khalil/6662-peer-id-specific-decay

    @kc1116
    kc1116 authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    1998a1b View commit details
    Browse the repository at this point in the history

  26. fix lint

    @kc1116
    kc1116 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    dffc321 View commit details
    Browse the repository at this point in the history

  27. Merge branch 'master' of github.com:onflow/flow-go into khalil/6662-p… 

    …eer-id-specific-decay
    @kc1116
    kc1116 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    fb346e0 View commit details
    Browse the repository at this point in the history