[Access] Use local event for AccessAPI get events endpoints

[peterargue]

Closes: #4751

Use locally indexed events for GetEvents* endpoints

[codecov-commenter]

Codecov Report

Attention: 43 lines in your changes are missing coverage. Please review.

Comparison is base (6e8c3b7) 56.42% compared to head (f8dc637) 54.46%.
Report is 24 commits behind head on master.

Files	Patch %	Lines
engine/access/rpc/backend/backend_events.go	69.23%	21 Missing and 7 partials ⚠️
engine/access/rpc/backend/config.go	28.57%	10 Missing ⚠️
utils/unittest/fixtures.go	0.00%	2 Missing ⚠️
engine/access/rest/routes/test_helpers.go	87.50%	1 Missing ⚠️
engine/access/rpc/backend/backend_accounts.go	75.00%	1 Missing ⚠️
engine/access/rpc/backend/backend_scripts.go	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4851      +/-   ##
==========================================
- Coverage   56.42%   54.46%   -1.96%     
==========================================
  Files         981      815     -166     
  Lines       93053    75174   -17879     
==========================================
- Hits        52504    40943   -11561     
+ Misses      36662    31265    -5397     
+ Partials     3887     2966     -921     

Flag	Coverage Δ
unittests	54.46% <70.94%> (-1.96%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zhangchiqing]

Do we need to validate the event type?

[peterargue]

the target is only used for effectively a string comparison, so it's pretty benign, but I can add it.

[zhangchiqing]

Do we need to restrict the number of blocks to query events from? Or the caller has checked that?

[peterargue]

the caller checks that

here

flow-go/engine/access/rpc/backend/backend_events.go

Lines 52 to 55 in ce9c12a

	if rangeSize > uint64(b.maxHeightRange) {
	return nil, status.Errorf(codes.InvalidArgument,
	"requested block range (%d) exceeded maximum (%d)", rangeSize, b.maxHeightRange)
	}

and here

flow-go/engine/access/rpc/backend/backend_events.go

Lines 109 to 111 in ce9c12a

	if uint(len(blockIDs)) > b.maxHeightRange {
	return nil, status.Errorf(codes.InvalidArgument, "requested block range (%d) exceeded maximum (%d)", len(blockIDs), b.maxHeightRange)
	}

[Guitarheroua]

Looks good for me