[ALSP] Synchronization Engine BatchRequest spam detection (Permissionless-related engine level spam detection)

[gomisha]

This PR adds ALSP spam level protection to the Synchronization Engine's BatchRequest message.

This is the third PR to implement ALSP misbehavior reporting at the engine level (first was 4590, second was 4665).

• probabilistically reporting misbehavior for BatchRequest messages depending on:
  • 1. how large the batch of block IDs is and
  • 2. how large the base probability is
• always reports misbehavior for BatchRequest messages with 0 block IDs
• creates default base probability for reporting BatchRequest message as spam - this setting should not report most BatchRequest messages as spam
• similar implementation and load testing as [ALSP] Synchronization Engine RangeRequest spam detection (Permissionless-related engine level spam detection)  #4665

ref: https://github.com/dapperlabs/flow-go/issues/6812

[codecov-commenter]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c5b6911) 52.85% compared to head (0d1fda2) 52.84%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4704      +/-   ##
==========================================
- Coverage   52.85%   52.84%   -0.01%     
==========================================
  Files         749      749              
  Lines       67135    67135              
==========================================
- Hits        35483    35480       -3     
- Misses      28966    28969       +3     
  Partials     2686     2686              

Flag	Coverage Δ
unittests	52.84% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
model/messages/synchronization.go	100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kc1116]

🚀

[yhassanzadeh13]

Except for the concern about the handling of irrecoverable errors; the rest looks very good.

[yhassanzadeh13]

Looks very good 👏 , thanks for applying the comments, there just one minor code styling comment left.

[jordanschalm]

Nice work, and thank you for the revisions.

Please address the point on changing the warn-level logs before merging.