[Verification] Refactor chunkVerifier unit tests #4698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterargue
changed the title
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #4698 +/- ##
=======================================
Coverage 55.10% 55.10%
=======================================
Files 922 922
Lines 85666 85666
=======================================
+ Hits 47205 47208 +3
+ Misses 34863 34861 -2
+ Partials 3598 3597 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhangchiqing
approved these changes
Sep 12, 2023
janezpodhostnik
approved these changes
Sep 14, 2023
peterargue
deleted the
petera/fix-service-event-exec-data-verification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
chunkVerifierunit tests used hand made stubs to test various scenarios. These were hard to modify and fragile.This PR refactors the tests to use testify mocks and simplify test setup. This is in preparation for a follow up PR that adds transaction results to execution data.