Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Networking] Fixes flakey networking integration tests #4691

Closed
wants to merge 21 commits into from

Conversation

yhassanzadeh13
Copy link
Contributor

@yhassanzadeh13 yhassanzadeh13 commented Sep 6, 2023

[Do not Review] WIP

Changes in this PR:

  1. Restore the skipped tests in PR [Networking] Refactoring Networking Layer for Improved Structure and Maintainability AND Eliminating Redundant Middleware Component #4664.
  2. Decouple the MeshEngineTestSuite into individual tests; the shared state among the tests was causing random flakiness.
  3. Skips two tests consistently failing on CI but passing locally: e0559bd

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06% 🎉

Comparison is base (4b8696a) 55.56% compared to head (02a30bb) 55.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4691      +/-   ##
==========================================
+ Coverage   55.56%   55.63%   +0.06%     
==========================================
  Files         929      928       -1     
  Lines       86275    86206      -69     
==========================================
+ Hits        47942    47961      +19     
+ Misses      34707    34614      -93     
- Partials     3626     3631       +5     
Flag Coverage Δ
unittests 55.63% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
network/p2p/test/fixtures.go 32.74% <0.00%> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yhassanzadeh13 yhassanzadeh13 marked this pull request as ready for review September 15, 2023 17:08
@yhassanzadeh13 yhassanzadeh13 marked this pull request as draft September 16, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants