Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cadence and change to ReadRandom #4679

Merged

Conversation

janezpodhostnik
Copy link
Contributor

Cadence upgrade to get some of the new things that are needed for atree register migration.

The change from unsafeRandom to readRandom due to cadence upgrade.

Copy link
Collaborator

@m-Peter m-Peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for this upgrade 💯
It certainly unblocks some PRs in downstream dependencies 🙏

@turbolent
Copy link
Member

Nice! Maybe we can tag a release on the Cadence side and update to that here?

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Patch coverage: 30.00% and project coverage change: -1.86% ⚠️

Comparison is base (eeeef3a) 54.55% compared to head (6d16a34) 52.69%.
Report is 445 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4679      +/-   ##
==========================================
- Coverage   54.55%   52.69%   -1.86%     
==========================================
  Files         917      738     -179     
  Lines       85900    66208   -19692     
==========================================
- Hits        46859    34889   -11970     
+ Misses      35448    28671    -6777     
+ Partials     3593     2648     -945     
Flag Coverage Δ
unittests 52.69% <30.00%> (-1.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
fvm/environment/facade_env.go 99.53% <ø> (+1.80%) ⬆️
fvm/environment/random_generator.go 67.30% <30.00%> (-1.93%) ⬇️

... and 242 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janezpodhostnik janezpodhostnik added this pull request to the merge queue Sep 14, 2023
Merged via the queue into master with commit 3d4c31f Sep 14, 2023
62 of 65 checks passed
@janezpodhostnik janezpodhostnik deleted the janez/upgrade-cadence-and-change-to-read-random branch September 14, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Execution Cadence Execution Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants