-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade cadence and change to ReadRandom #4679
Upgrade cadence and change to ReadRandom #4679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for this upgrade 💯
It certainly unblocks some PRs in downstream dependencies 🙏
Nice! Maybe we can tag a release on the Cadence side and update to that here? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4679 +/- ##
==========================================
- Coverage 54.55% 52.69% -1.86%
==========================================
Files 917 738 -179
Lines 85900 66208 -19692
==========================================
- Hits 46859 34889 -11970
+ Misses 35448 28671 -6777
+ Partials 3593 2648 -945
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Cadence upgrade to get some of the new things that are needed for atree register migration.
The change from unsafeRandom to readRandom due to cadence upgrade.