-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BFT Testing] Reducing load of BFT tests and improving test packages #4652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4652 +/- ##
==========================================
- Coverage 56.25% 55.03% -1.22%
==========================================
Files 653 819 +166
Lines 64699 78838 +14139
==========================================
+ Hits 36396 43389 +6993
- Misses 25362 32024 +6662
- Partials 2941 3425 +484
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
gomisha
reviewed
Aug 24, 2023
Co-authored-by: Misha <misha.rybalov@dapperlabs.com>
gomisha
reviewed
Aug 28, 2023
gomisha
reviewed
Aug 28, 2023
gomisha
reviewed
Aug 28, 2023
gomisha
reviewed
Aug 28, 2023
gomisha
reviewed
Aug 28, 2023
integration/tests/bft/protocol/disallowlisting/admin_command_disallowlisting_test.go
Outdated
Show resolved
Hide resolved
gomisha
reviewed
Aug 28, 2023
integration/tests/bft/protocol/disallowlisting/admin_command_disallowlisting_test.go
Outdated
Show resolved
Hide resolved
gomisha
reviewed
Aug 28, 2023
gomisha
reviewed
Aug 28, 2023
gomisha
reviewed
Aug 28, 2023
gomisha
reviewed
Aug 28, 2023
Co-authored-by: Misha <misha.rybalov@dapperlabs.com>
Co-authored-by: Misha <misha.rybalov@dapperlabs.com>
Co-authored-by: Misha <misha.rybalov@dapperlabs.com>
Co-authored-by: Misha <misha.rybalov@dapperlabs.com>
kc1116
approved these changes
Aug 29, 2023
This reverts commit 2ad6e35.
…low-go into yahya/6857-bft-testing-ci-fix-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces essential corrections to enhance the stability of the BFT integration tests. The improvements are as follows:
This PR also adds readme for individual BFT test packages.
This PR also temporarily quarantines the following tests, which will be un-quarantined once we split the
network
CI job on unit tests into smaller jobs:TestStubEngineTestSuite/TestDuplicateMessageDifferentChan_Publish
MeshEngineTestSuite/TestMaxMessageSize_Multicast
MeshEngineTestSuite/TestMaxMessageSize_Publish
EchoEngineTestSuite/TestDuplicateMessageParallel_Publish
EchoEngineTestSuite/TestDuplicateMessageDifferentChan_Multicast
EchoEngineTestSuite/TestEchoMultiMsgAsync_Multicast
EchoEngineTestSuite/TestDuplicateMessageParallel_Multicast