Khalil/6819 simplify rpc inspector validation

[kc1116]

This PR simplifies RPC control message validation.

1. Instead of using a Safety and Hard threshold, we will now shrink the RPC using a configured MaxSampleSize. Each subsequent control message that is not included in the sample will be resent in a subsequent RPC.
2. A single inspector worker will validate an entire RPC rather than a single control message type.
3. RPC validation will fail on the first encountered validation error enforcing a 1 notification per RPC rule.

Tests removed:

• TestErrHardThresholdRoundTrip and TestErrRateLimitedControlMsgRoundTrip were removed because the associated errors no longer exist.
• TestValidationInspector_SafetyThreshold, TestValidationInspector_HardThresholdIHave_Detection, and TestValidationInspector_RateLimitedPeer_Detection were also removed due to the simplification, which eliminated safety and hard thresholds as well as rate limiting.

[yhassanzadeh13]

While the ControlMsgValidationInspector is covered by integration tests in the insecure package, its critical role in our codebase warrants dedicated unit tests. These tests should focus on both successful and unsuccessful RPC processing:

1. Verify that legitimate RPCs (iHave, iWant, Graft, Prune) do not trigger misbehavior notifications.
2. Test for iHave misbehaviors, ensuring each case triggers a misbehavior notification.
3. Similarly, validate that iWant misbehaviors trigger misbehavior notifications.
4. Confirm that GRAFT and PRUNE misbehaviors also lead to misbehavior notifications.

Please include these tests in this PR or create an issue for them to be implemented in a subsequent PR.

[kc1116]

Currently in progress here https://github.com/dapperlabs/flow-internal/issues/1902

[codecov-commenter]

Codecov Report

Patch coverage: 1.40% and project coverage change: -4.58% ⚠️

Comparison is base (0648496) 56.74% compared to head (2bdb75b) 52.16%.
Report is 26 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4642      +/-   ##
==========================================
- Coverage   56.74%   52.16%   -4.58%     
==========================================
  Files         876      734     -142     
  Lines       80357    65958   -14399     
==========================================
- Hits        45597    34406   -11191     
+ Misses      31208    28922    -2286     
+ Partials     3552     2630     -922     

Flag	Coverage Δ
unittests	52.16% <1.40%> (-4.58%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...dule/metrics/gossipsub_rpc_validation_inspector.go	0.00% <0.00%> (ø)
module/metrics/noop.go	0.00% <0.00%> (ø)
...validation/control_message_validation_inspector.go	0.00% <0.00%> (ø)
network/p2p/inspector/validation/errors.go	80.00% <ø> (-5.72%)	⬇️
...2p/inspector/validation/inspect_message_request.go	0.00% <0.00%> (ø)
network/p2p/p2pbuilder/libp2pNodeBuilder.go	0.00% <0.00%> (ø)
network/p2p/tracer/internal/rpc_sent_tracker.go	88.88% <ø> (ø)
network/netconf/flags.go	30.12% <33.33%> (+4.61%)	⬆️
network/p2p/test/fixtures.go	32.96% <33.33%> (ø)
network/p2p/scoring/registry.go	89.93% <100.00%> (+0.06%)	⬆️

... and 229 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.