[Access] Update REST metrics to use route name for all types #4571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4571 +/- ##
==========================================
- Coverage 56.25% 49.73% -6.52%
==========================================
Files 653 98 -555
Lines 64699 6651 -58048
==========================================
- Hits 36396 3308 -33088
+ Misses 25362 3175 -22187
+ Partials 2941 168 -2773
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kc1116
reviewed
Jul 19, 2023
module/metrics/rest_api.go
Outdated
| // mapURLToRoute uses the urlToRouteMapper callback to convert a URL to a route name | ||
| // This normalizes the URL, removing dynamic information converting it to a static string | ||
| func (r *RestCollector) mapURLToRoute(url string) string { | ||
| if r.urlToRouteMapper == nil { |
There was a problem hiding this comment.
Looking at the code, this callback should never be set to nil. We should return an error in the constructor if it is, that should indicate a bug.
kc1116
approved these changes
Jul 19, 2023
koko1123
approved these changes
Jul 19, 2023
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jul 19, 2023
4571: [Access] Update REST metrics to use route name for all types r=peterargue a=peterargue The REST metrics handler passes the original route into the collector, causing high cardinality and performance issues on the prometheus servers. We attempted to fix this with #4452, but only updated 1 of 4 metrics that were reporting the URL. This PR updates all metrics to use the mapped route name. It also removes a bunch of unnecessary config and aligns the collector with the other metrics collectors in flow-go Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
|
Build failed: |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jul 20, 2023
4571: [Access] Update REST metrics to use route name for all types r=peterargue a=peterargue The REST metrics handler passes the original route into the collector, causing high cardinality and performance issues on the prometheus servers. We attempted to fix this with #4452, but only updated 1 of 4 metrics that were reporting the URL. This PR updates all metrics to use the mapped route name. It also removes a bunch of unnecessary config and aligns the collector with the other metrics collectors in flow-go Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
|
Build failed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The REST metrics handler passes the original route into the collector, causing high cardinality and performance issues on the prometheus servers. We attempted to fix this with #4452, but only updated 1 of 4 metrics that were reporting the URL.
This PR updates all metrics to use the mapped route name. It also removes a bunch of unnecessary config and aligns the collector with the other metrics collectors in flow-go