Update Go version to 1.20 #4563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4563 +/- ##
==========================================
- Coverage 56.25% 54.46% -1.79%
==========================================
Files 653 914 +261
Lines 64699 85278 +20579
==========================================
+ Hits 36396 46447 +10051
- Misses 25362 35247 +9885
- Partials 2941 3584 +643
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FVM Benchstat comparisonThis branch with compared with the base branch onflow:master commit 9682381 The command Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
tarakby
requested review from
gomisha,
yhassanzadeh13,
ramtinms,
janezpodhostnik,
AlexHentschel and
peterargue
as code owners
peterargue
reviewed
Jul 17, 2023
utils/unittest/fixtures.go
Outdated
| @@ -417,7 +417,7 @@ func BlockHeaderFixture(opts ...func(header *flow.Header)) *flow.Header { | |||
|
|
|||
| func CidFixture() cid.Cid { | |||
| data := make([]byte, 1024) | |||
| _, _ = rand.Read(data) | |||
| _, _ = crand.Read(data) | |||
There was a problem hiding this comment.
it'd be best not to swallow this error. Maybe update the method either to accept a testing object and require no error, or just return the error. It doesn't look like this fixture is even used.
There was a problem hiding this comment.
I would rather delete non-used functions. Thanks for the flag!
There was a problem hiding this comment.
At the same time, for fixtures I think failing randomness would just lead to the byte array remaining all zeros, which is still a valid "fixture".
peterargue
approved these changes
Jul 17, 2023
janezpodhostnik
approved these changes
Jul 18, 2023
|
bors merge |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Go version to 1.20