[EN] Fix uploader missing events in block data uploaded to GCP #4562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only last event is included in block data (repeated n times). This commit fixes the bug and includes all events.
koko1123
approved these changes
Jul 14, 2023
koko1123
reviewed
Jul 14, 2023
| eventsList := computationResult.AllEvents() | ||
| events := make([]*flow.Event, len(eventsList)) | ||
| for i := 0; i < len(eventsList); i++ { | ||
| events[i] = &eventsList[i] | ||
| } | ||
|
|
||
| trieUpdates := make( |
There was a problem hiding this comment.
would this be affected as well?
There was a problem hiding this comment.
No, that code block avoids the problem and is unaffected by the bug. Also the unit test improved by this PR checks for the problem so tests won't pass anymore if that code is affected by the bug.
The bug in the old code is caused by reusing variable returned by range which is a per-loop variable (it is not a per-iteration variable). So &variable would point to same variable each iteration. Each iteration was just appending the same variable's address to events.
events := make([]*flow.Event, 0)
for _, e := range computationResult.AllEvents() {
events = append(events, &e) // BUG: same address appended each iteration.
}All elements of events is the same address of the same e when loop finishes.
FVM Benchstat comparisonThis branch with compared with the base branch onflow:master commit 72b4db9 The command Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov Report
@@ Coverage Diff @@
## master #4562 +/- ##
==========================================
- Coverage 56.25% 54.45% -1.81%
==========================================
Files 653 914 +261
Lines 64699 85200 +20501
==========================================
+ Hits 36396 46392 +9996
- Misses 25362 35219 +9857
- Partials 2941 3589 +648
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fxamacker
changed the title
fxamacker
changed the title
This was referenced Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4558
Problem
The uploader in
engine/execution/ingestion/uploader/is only uploading the last event instead of all events.The problem is caused by reusing variable returned by
rangewhich is a per-loop variable (it is not a per-iteration variable). Each iteration was just appending the same variable's address toevents.When loop finishes, all elements of
eventsis the same address of the samee.Solution
This PR:
rangeloop with an index-based loop.2023-07-17 EDIT: Added more details about the problem and fix because there was a question about it.