Git tag validation #4552
Merged
Git tag validation #4552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezpodhostnik
requested review from
gomisha,
zhangchiqing and
peterargue
as code owners
janezpodhostnik
force-pushed
the
janez/git-tag-validation
branch
2 times, most recently
from
a581224
to
db9b4e1
Compare
peterargue
approved these changes
Jul 16, 2023
koko1123
approved these changes
Jul 27, 2023
janezpodhostnik
force-pushed
the
janez/git-tag-validation
branch
from
db9b4e1
to
9d1c066
Compare
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jul 28, 2023
4552: Git tag validation r=janezpodhostnik a=janezpodhostnik closes: #4414 This PR makes it mandatory that the git tags pushed to this repository are in semver format, with an optinal "(.+\/)*v" prefix. meaning that these are all valid: crypto/v0.24.5-fvm, tools/flaky_test_monitor/v0.23.5, v0.23.5, 0.23.5-fvm Changes: - CI that checks the tag on git push. This doesn't prevent pushing or using incorrect tags, but it does notify the user (through a failed github action) that something isn't ok - Nodes will fail to startup if they have a version that cannot be parsed (is a semver with an optional "v" prefix) - integration tests CI have git clone with `fetch-depth: 0` this is so that all tags are fetched, so that the version is detected correctly. - some renaming to make the code clearer. Co-authored-by: Janez Podhostnik <janez.podhostnik@gmail.com>
|
Build failed: |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jul 28, 2023
4552: Git tag validation r=janezpodhostnik a=janezpodhostnik closes: #4414 This PR makes it mandatory that the git tags pushed to this repository are in semver format, with an optinal "(.+\/)*v" prefix. meaning that these are all valid: crypto/v0.24.5-fvm, tools/flaky_test_monitor/v0.23.5, v0.23.5, 0.23.5-fvm Changes: - CI that checks the tag on git push. This doesn't prevent pushing or using incorrect tags, but it does notify the user (through a failed github action) that something isn't ok - Nodes will fail to startup if they have a version that cannot be parsed (is a semver with an optional "v" prefix) - integration tests CI have git clone with `fetch-depth: 0` this is so that all tags are fetched, so that the version is detected correctly. - some renaming to make the code clearer. Co-authored-by: Janez Podhostnik <janez.podhostnik@gmail.com>
|
Build failed: |
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #4414
This PR makes it mandatory that the git tags pushed to this repository are in semver format, with an optinal "(.+/)*v" prefix. meaning that these are all valid: crypto/v0.24.5-fvm, tools/flaky_test_monitor/v0.23.5, v0.23.5, 0.23.5-fvm
Changes:
fetch-depth: 0this is so that all tags are fetched, so that the version is detected correctly.