Switch crypto library to onflow/crypto
#4551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 Experimental
The latest version of
flow-go-sdkuses the crypto library from https://github.com/onflow/crypto, where as flow-go repo is using the crypto library from https://github.com/onflow/flow-go/tree/master/crypto.Because of this, updating to the latest Cadence (and hence flow-go-sdk), requires converting crypto-related types between the two libraries. But that can lead to inconsistencies (always need to keep the two libraries synced, etc.) and hence is a bit brittle.
Alternatively, this PR updates
flow-goto also use the new crypto library from onflow/crypto, so the type conversions are not needed.