Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Rename without_netgo tag to without-netgo #4548

Merged
merged 2 commits into from
Jul 17, 2023
Merged

[CI] Rename without_netgo tag to without-netgo #4548

merged 2 commits into from
Jul 17, 2023

Conversation

peterargue
Copy link
Contributor

Underscores are not valid in semantic versioning strings. Update the without_netgo prefix to without-netgo

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2023 •
edited
Loading

Codecov Report

Merging #4548 (8b2a7a5) into master (2528190) will decrease coverage by 1.40%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4548      +/-   ##
==========================================
- Coverage   56.25%   54.85%   -1.40%     
==========================================
  Files         653      816     +163     
  Lines       64699    78573   +13874     
==========================================
+ Hits        36396    43103    +6707     
- Misses      25362    32054    +6692     
- Partials     2941     3416     +475
Flag Coverage Δ
unittests 54.85% <0.00%> (-1.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/scaffold.go 14.78% <0.00%> (+0.02%) ⬆️
module/metrics/network.go 0.00% <0.00%> (ø)
module/metrics/noop.go 0.00% <0.00%> (ø)
utils/unittest/unittest.go 7.48% <0.00%> (-0.12%) ⬇️

... and 169 files with indirect coverage changes

janezpodhostnik
janezpodhostnik approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@janezpodhostnik janezpodhostnik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

@peterargue
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Jul 17, 2023
@bors @peterargue
Merge #4548
eb3592b 
4548: [CI] Rename without_netgo tag to without-netgo r=peterargue a=peterargue

Underscores are not valid in semantic versioning strings. Update the `without_netgo` prefix to `without-netgo`

Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Jul 17, 2023

Build failed:

@peterargue peterargue merged commit e26bc28 into master Jul 17, 2023
33 checks passed
@peterargue peterargue deleted the petera/rename-without-netgo-tag branch July 17, 2023 21:08
@janezpodhostnik janezpodhostnik mentioned this pull request Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramtinms ramtinms ramtinms approved these changes

@janezpodhostnik janezpodhostnik janezpodhostnik approved these changes

Assignees

@j1010001 j1010001

@janezpodhostnik janezpodhostnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peterargue @codecov-commenter @ramtinms @janezpodhostnik @j1010001